Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure :noh disables hlsearch until the next search is done #3749

Merged
merged 2 commits into from
May 14, 2019
Merged

Make sure :noh disables hlsearch until the next search is done #3749

merged 2 commits into from
May 14, 2019

Conversation

J-Fields
Copy link
Member

What this PR does / why we need it:
hlsearch was enabled when a search was initiated (/), not when you actually search (<enter>). The result is that :noh would be undone when a search is cancelled (/<esc>).

Which issue(s) this PR fixes
Fixes #3748

@jpoon
Copy link
Member

jpoon commented May 13, 2019

Resolve conflicts?

@J-Fields
Copy link
Member Author

Resolve conflicts?

@jpoon Done.

@jpoon jpoon merged commit d3a5a03 into VSCodeVim:master May 14, 2019
@J-Fields J-Fields deleted the noh-fix branch May 15, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancelling a search should not undo :noh
2 participants