Move prettier configuration to .prettierrc #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that people can develop with the intended prettier configuration in their local editor (as will look for a .prettierrc by default), while maintaining the `forceprettier` functionality (and keeps the configuration in one place)
stevenguh
pushed a commit
to stevenguh/Vim
that referenced
this pull request
Aug 27, 2019
This means that people can develop with the intended prettier configuration in their local editor (as will look for a .prettierrc by default), while maintaining the `forceprettier` functionality (and keeps the configuration in one place)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move prettier configuration to
.prettierrc(see https://prettier.io/docs/en/configuration.html)This means that people can develop with the intended prettier configuration in their local editor (as will look for a
.prettierrcby default) while maintaining theforceprettierfunctionality (and keeps the configuration in one place)Which issue(s) this PR fixes
None that I could find
Special notes for your reviewer:
The
prettiercli will pick up this file during the gulpforceprettierstepHopefully the intent of this makes sense (eg. I personally run prettier in its default mode so need to update my config depending on the repo I'm working on, unless there's some config for my editor to pick up)
The configuration could be moved to within the
package.json(as per the link above) if that felt like a better home (I'm personally quite used to.rcfiles, but perhaps others aren't)Funnily enough, prettier reformatted
gulpfile.jsonce the line length of the cli command was reduced