Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom keyboard mapping (fixes #432). Fix duplicate definition… #447

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Jul 14, 2016

  • Commit message has a short title & issue references
  • Commits are squashed
  • It builds and tests pass (e.g gulp tslint)

VSCode has done some great work in handling international keyboards. As such, this makes are own keyboard mapping defunct. Removing the custom keyboard mappings.

This PR also fixes the build. As the /typings folder is now checked-in, we no longer need to modify it in the gulp init step.

@jpoon jpoon merged commit 5a2bce3 into master Jul 14, 2016
@jpoon jpoon deleted the keyboard-mapper branch July 14, 2016 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant