Improve multicursor support

src/actions/commands/insert.ts

@@ -244,9 +244,9 @@ export class CommandBackspaceInInsertMode extends BaseCommand {
 
   public async exec(position: Position, vimState: VimState): Promise<VimState> {
     const line = TextEditor.getLineAt(position).text;
-    const selection = TextEditor.getSelection();
+    const selection = vimState.editor.selections.find(s => s.contains(position));
 
-    if (!selection.isEmpty) {
+    if (selection && !selection.isEmpty) {
       // If a selection is active, delete it
       vimState.recordedState.transformations.push({
         type: 'deleteRange',
@@ -293,18 +293,11 @@ export class CommandInsertInInsertMode extends BaseCommand {
   public async exec(position: Position, vimState: VimState): Promise<VimState> {
     const char = this.keysPressed[this.keysPressed.length - 1];
 
-    if (vimState.isMultiCursor) {
-      vimState.recordedState.transformations.push({
-        type: 'insertText',
-        text: char,
-        position: vimState.cursorStopPosition,
-      });
-    } else {
-      vimState.recordedState.transformations.push({
-        type: 'insertTextVSCode',
-        text: char,
-      });
-    }
+    vimState.recordedState.transformations.push({
+      type: 'insertTextVSCode',
+      text: char,
+      isMultiCursor: vimState.isMultiCursor,
+    });
 
     return vimState;
   }

src/mode/modeHandler.ts

@@ -30,6 +30,9 @@ import {
   areAnyTransformationsOverlapping,
   isTextTransformation,
   TextTransformations,
+  areAllSameTransformation,
+  isMultiCursorTextTransformation,
+  InsertTextVSCodeTransformation,
 } from './../transformations/transformations';
 import { globalState } from '../state/globalState';
 import { reportSearch } from '../util/statusBarTextUtils';
@@ -834,7 +837,13 @@ export class ModeHandler implements vscode.Disposable {
     const textTransformations: TextTransformations[] = transformations.filter(x =>
       isTextTransformation(x)
     ) as any;
-    const otherTransformations = transformations.filter(x => !isTextTransformation(x));
+    const multicursorTextTransformations: InsertTextVSCodeTransformation[] = transformations.filter(
+      x => isMultiCursorTextTransformation(x)
+    ) as any;
+
+    const otherTransformations = transformations.filter(
+      x => !isTextTransformation(x) && !isMultiCursorTextTransformation(x)
+    );
 
     let accumulatedPositionDifferences: { [key: number]: PositionDiff[] } = {};
 
@@ -907,6 +916,26 @@ export class ModeHandler implements vscode.Disposable {
       }
     }
 
+    if (multicursorTextTransformations.length > 0) {
+      if (areAllSameTransformation(multicursorTextTransformations)) {
+        /**
+         * Apply the transformation only once instead of to each cursor
+         * if they are all the same.
+         *
+         * This lets VSCode do multicursor snippets, auto braces and
+         * all the usual jazz VSCode does on text insertion.
+         */
+        const { text } = multicursorTextTransformations[0];
+
+        // await vscode.commands.executeCommand('default:type', { text });
+        await TextEditor.insert(text);
+      } else {
+        this._logger.warn(
+          `Unhandled multicursor transformations. Not all transformations are the same!`
+        );
+      }
+    }
+
     for (const command of otherTransformations) {
       switch (command.type) {
         case 'insertTextVSCode':

src/transformations/transformations.ts

@@ -99,6 +99,11 @@ export interface InsertTextVSCodeTransformation {
    */
   text: string;
 
+  /**
+   * Whether this transformation was created in multicursor mode.
+   */
+  isMultiCursor?: boolean;
+
   /**
    * The index of the cursor that this transformation applies to.
    */
@@ -291,6 +296,9 @@ export const isTextTransformation = (x: Transformation): x is TextTransformation
     x.type === 'moveCursor'
   );
 };
+export const isMultiCursorTextTransformation = (x: Transformation): Boolean => {
+  return (x.type === 'insertTextVSCode' && x.isMultiCursor) ?? false;
+};
 
 const getRangeFromTextTransformation = (transformation: TextTransformations): Range | undefined => {
   switch (transformation.type) {
@@ -330,3 +338,16 @@ export const areAnyTransformationsOverlapping = (transformations: TextTransforma
 
   return false;
 };
+
+export const areAllSameTransformation = (transformations: Transformation[]): Boolean => {
+  const firstTransformation = transformations[0];
+
+  return transformations.every(t => {
+    for (const [key, value] of Object.entries(firstTransformation)) {
+      if (t[key] !== value) {
+        return false;
+      }
+    }
+    return true;
+  });
+};