Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of opener for nested text objects #472

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

ascandella
Copy link
Contributor

Prior to this commit, we would naively search for the previous e.g. "{"
character when you wanted to "ci{".

However, if you were inside two levels of nesting:

  one {
    two {}
    // cursor here
  }

Then the backwards search would take you to the wrong place.

Switching to the same logic for forward searching, we now handle this
case properly.

Prior to this commit, we would naively search for the previous e.g. "{"
character when you wanted to "ci{".

However, if you were inside two levels of nesting:

  one {
    two {}
    // cursor here
  }

Then the backwards search would take you to the wrong place.

Switching to the same logic for forward searching, we now handle this
case properly.
@jpoon
Copy link
Member

jpoon commented Jul 19, 2016

Awesome! Thanks @sectioneight 🚀

@jpoon jpoon merged commit 7a5e273 into VSCodeVim:master Jul 19, 2016
@ascandella ascandella deleted the fix-back branch July 19, 2016 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants