improves bracket undo behavior when vscode autocloses brackets #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const letterToTheRight = TextEditor.getLineAt(vimState.cursorPosition).text[vimState.cursorPosition.character]; | ||
| if (letterToTheRight !== undefined) { | ||
| switch (key) { | ||
| case "{": |
There was a problem hiding this comment.
Generally when there are giant switch statements that's a sign that you could better represent your stuff as a data structure. In this case, maybe something like this:
const pairings = {
"{" : "}",
"[" : "]",
"<" : ">",
/* etc... */
}
There was a problem hiding this comment.
I think this idea would also let you DRY up this code a little bit. It's a little repetitive right now.
|
Ok definitely a little cleaner now |
|
Can you leverage this? https://github.com/VSCodeVim/Vim/blob/master/src/matching/matcher.ts |
|
I should be able to... this looks perfect... |
|
Wonderful, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change & check your PR against this list, thanks:
gulp tslint)More info can be found by clicking the "guidelines for contributing" link above.