Some visual block fixes #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this fixes #658 as well |
| blockLines += 1; | ||
| } | ||
|
|
||
| // Do a regular visual 'change' if only 1 line of block is selected |
There was a problem hiding this comment.
Why do we have to special case this?
There was a problem hiding this comment.
Will remove the special case and improve the insert block mode a little bit more, visual block is just a little funky, I will try to fix the root funkiness there instead of this way
|
Much better :) |
xconverge
changed the title
|
This looks good. Can you bring it up to date with master please? Then I'll merge it. |
|
good to go |
|
Thanks @xconverge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change & check your PR against this list, thanks:
gulp tslint)More info can be found by clicking the "guidelines for contributing" link above.