-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement :wa[ll] command (write all) #671
Conversation
Is this a WIP? I still see some TODO comments. |
@johnfn I think it is useful in it's current form as partial implementation of |
} | ||
|
||
async execute() : Promise<void> { | ||
// TODO : ignore untitled documents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can access textEditor.document.isUntitled
to see if it's untitled.
Two tiny comments and all others are good to me. |
LGTM; however ping @markrendle about @rebornix's comment about EOF. And can you bring this up to date with master? |
1e4c60d
to
2628160
Compare
Thanks @johnfn, it should be now up to date with master. |
@mleech I see, thanks for helping understand the code better :) LGTM as well. Rebase the code and let's ship it! |
Thanks @mleech. I realized following the merge a better name for the class/filename may be |
@jpoon yeah you're right, it would be a better name. I mistakenly thought all the other classes/files were named after the long version of the vim command - hence |
Implements a basic
:wa[ll]
command (http://vimdoc.sourceforge.net/htmldoc/editing.html#:wall)It currently just triggers vscode's
workbench.action.files.saveAll
command, so the bang version (wa!
) doesn't overwrite readonly files.Yay! We love PRs! 🎊
Please include a description of your change & check your PR against this list, thanks:
gulp tslint
)More info can be found by clicking the "guidelines for contributing" link above.