-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #739 #767
fixes #739 #767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this handle, say, c}
in the same situation?
I think this may be a special case on w
, not c
.
Add your review
hah ok so you are right, I fixed this on w, however c} does not work right (and did not before so I will fix that as well since you brought it up) |
Just one comment and you may also want to write a simple test to cover this scenario. |
I don't understand why this behavior would happen for
|
@johnfn what is the special case I have in "c" now? |
My bad, @xconverge. I misread your PR. (And also I completely missed your reply. I have trouble with Github's notification system...) It looks good to me. If you bring it up to date, I'll merge it! :) |
Weird bug, weird fix, but I am ok with it if you are
Yay! We love PRs! 🎊
Please include a description of your change & check your PR against this list, thanks:
gulp tslint
)More info can be found by clicking the "guidelines for contributing" link above.