Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #7670: support put = #7892

Merged
merged 6 commits into from
Mar 27, 2023

Conversation

elazarcoh
Copy link
Contributor

What this PR does / why we need it:
Allow expressions in put command.
Implemented range(start, stop, step=1).
example:
:put=range(10,5,-1)

Which issue(s) this PR fixes
fixes #7670

Special notes for your reviewer:

@elazarcoh
Copy link
Contributor Author

This also set up groundwork for #7136

@J-Fields
Copy link
Member

This also set up groundwork for #7136

I've got a branch I haven't touched for like a year with some decent progress on expression parsing & evaluating. I'll try to get it to a MVP state and push - then we can hook it up to this. Let me know if you'd be interested in working off that branch, also.

@elazarcoh
Copy link
Contributor Author

This also set up groundwork for #7136

I've got a branch I haven't touched for like a year with some decent progress on expression parsing & evaluating. I'll try to get it to a MVP state and push - then we can hook it up to this. Let me know if you'd be interested in working off that branch, also.

I think it would be wise to start off somewhere, your branch might be a good place for it, as I'm sure how it would be best to design the code anyway.

@J-Fields
Copy link
Member

See #7920

@elazarcoh
Copy link
Contributor Author

See #7920

This is much more comprehensive.
What will be a good way for me to contribute for this PR? What is still needed for it to be ready?

@J-Fields
Copy link
Member

This is much more comprehensive.

Yeah I got further along than I'd remembered, actually

What will be a good way for me to contribute for this PR? What is still needed for it to be ready?

I'd like to get some more polish on it before releasing it, but probably not too much more needs to be done before it's merge-worthy. I think sometime this week I'll release v1.23.3, then merge #7920. At that point, we can re-group and see what the best path forward is.

We can target #7920, this MR, and #7893 for 1.24.0. Pretty exciting stuff!

@J-Fields
Copy link
Member

Thanks @elazarcoh!

@J-Fields J-Fields merged commit 02ede6c into VSCodeVim:master Mar 27, 2023
@elazarcoh elazarcoh deleted the elazarcoh/7670-Support-`put-=` branch March 27, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support :pu[t] =
2 participants