fixes #784 #814
Merged
fixes #784 #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnfn
requested changes
Oct 1, 2016
| let stop = Position.FromVSCodePosition(vscode.window.activeTextEditor.selection.end); | ||
|
|
||
| // We want to swap the cursor start stop positions based on which direction we are moving, up or down | ||
| if (start.line < position.line) { |
There was a problem hiding this comment.
You can do a swap like this: [a, b] = [b, a]
You could also write this whole block like this:
return { start: Position.earlierOf(start, stop), stop: Position.laterOf(start, stop) }
There was a problem hiding this comment.
Aye, I will change it, this is where all readability goes away in my opinion. I can solve this by just not reading it again :)
|
Ideally we would refactor stuff to use |
|
Good to go I think |
|
Thanks cubed, @xconverge!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change and ensure:
gulp)More info can be found on our contribution guide.