Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow A while in visual mode #816

Merged
merged 4 commits into from
Oct 5, 2016
Merged

Fix to allow A while in visual mode #816

merged 4 commits into from
Oct 5, 2016

Conversation

xconverge
Copy link
Member

Yay! We love PRs! 🎊

Please include a description of your change and ensure:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

@xconverge xconverge changed the title -fix to allow A while in visual mode Fix to allow A while in visual mode Oct 1, 2016
@johnfn
Copy link
Member

johnfn commented Oct 1, 2016

This is the Visual Block Mode A. You want the Insert Mode A, right?

@xconverge
Copy link
Member Author

@johnfn no idea what I was doing here, really don't

Same as the other one though, I can find any regressions but can't say I am fluent enough with the commands to know exactly how they could work on all of the edge cases

@johnfn
Copy link
Member

johnfn commented Oct 5, 2016

Been thinking about this more and I think it's okay. Could you just remove the line

mustBeFirstKey = false;

entirely (as mustBeFirstKey defaults to false so there's no reason to set it).

Same thing with your other PR.

@johnfn johnfn merged commit 434c21e into VSCodeVim:master Oct 5, 2016
@johnfn
Copy link
Member

johnfn commented Oct 5, 2016

Thanks, @xconverge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants