Fixes arrow navigation to EOL while in insert #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnfn
requested changes
Oct 5, 2016
| newPosition = new Position(newPosition.line, Math.max(newPosition.getLineEnd().character - 1, 0)); | ||
| if (this._vimState.currentMode === ModeName.Insert) { | ||
| // This lets you use arrow keys to move to the end of the line | ||
| newPosition = new Position(newPosition.line, Math.max(newPosition.getLineEnd().character, 0)); |
There was a problem hiding this comment.
Is this necessary? The position will already be bounded between 0 and the length of the line anyways.
There was a problem hiding this comment.
Where will it be bounded?
There was a problem hiding this comment.
Ah I see, let me try an adjustment
|
Great, thanks @xconverge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change and ensure:
gulp)More info can be found on our contribution guide.