Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab keybinding from blocking Find menu tab-navigation #8505

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

devrelm
Copy link
Contributor

@devrelm devrelm commented Jul 19, 2023

What this PR does / why we need it:

See #7000 (comment)

In short, the extension's tab and tab+shift keybindings are checking for editorFocus instead of editorTextFocus.

editorFocus is defined as:

An editor has focus, either the text or a widget.

emphasis mine

Because editorFocus is true when the user tabs in the editor-level Find menu (or at the very least it's true after tabbing once to focus the "Match Case" button) the user cannot tab past "Match Case" to "Match Whole Word", "Use Regular Expression", or beyond.

This PR updates the keybindings' where clause to use editorTextFocus in place of editorFocus.

Which issue(s) this PR fixes

fixes #7000

Special notes for your reviewer:

@dominicpalmer
Copy link
Contributor

Nice. @J-Fields, please can this be merged?

@devrelm devrelm force-pushed the devrelm/fix-non-editor-tab-nav branch from 7dc9cbd to 7424f10 Compare August 2, 2023 16:49
@J-Fields J-Fields merged commit 00cbd68 into VSCodeVim:master Aug 29, 2023
@J-Fields
Copy link
Member

Thanks a lot!

@devrelm devrelm deleted the devrelm/fix-non-editor-tab-nav branch October 17, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants