Fix tab keybinding from blocking Find menu tab-navigation #8505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See #7000 (comment)
In short, the extension's
tab
andtab+shift
keybindings are checking foreditorFocus
instead ofeditorTextFocus
.editorFocus
is defined as:emphasis mine
Because
editorFocus
istrue
when the user tabs in the editor-level Find menu (or at the very least it'strue
after tabbing once to focus the "Match Case" button) the user cannot tab past "Match Case" to "Match Whole Word", "Use Regular Expression", or beyond.This PR updates the keybindings'
where
clause to useeditorTextFocus
in place ofeditorFocus
.Which issue(s) this PR fixes
fixes #7000
Special notes for your reviewer: