Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new logo icon #852

Merged
merged 5 commits into from
Oct 6, 2016
Merged

Add new logo icon #852

merged 5 commits into from
Oct 6, 2016

Conversation

kevincoleman
Copy link
Contributor

New logo icon file
Updated banner color to match logo
logo source design files in design/

@xconverge
Copy link
Member

This is awesome, thanks @kevincoleman

@jpoon
Copy link
Member

jpoon commented Oct 6, 2016

Mind actually putting it all under /images?

@jpoon
Copy link
Member

jpoon commented Oct 6, 2016

@kevincoleman are the edges of the icon also #208ecd? As we're changing the banner color to #208ecd on https://marketplace.visualstudio.com/items?itemName=vscodevim.vim, want to make sure that they don't bleed into the icon.

@kevincoleman
Copy link
Contributor Author

@jpoon Ahhh. Good point. The edges are the also #208ecd, so that won’t work too well.

Options:
add a white border or background around the icon design to give it somewhat of a “sticker” feel.
pick another banner color so as to avoid the bleed issue.
any other ideas?

@jpoon
Copy link
Member

jpoon commented Oct 6, 2016

Let's go with the easy one -- different banner color.

@jpoon
Copy link
Member

jpoon commented Oct 6, 2016

Sweeet. Thanks @kevincoleman .

@jpoon jpoon merged commit e4217c6 into VSCodeVim:master Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants