-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Post 1.0] Two way syncing of Vim and Code's configuration #913
Conversation
e67a494
to
d1d4d39
Compare
With this PR, you should be able to manage configs through EX command and if it has overlap with Code, Code's configuration will be override and the new config will be stored in user's Besides, it requires Code 1.6. Please let me know when do you think is the best time to merge it. |
So this will actually directly update the user's settings.json if they do something like I'm otherwise fine to merge this! You guys are the ones with stats about 1.6 percentage usage after all. 😉 |
We've released Code 1.6 for a week and within these 7 days, 75% of the extension activations are from Code 1.6+, 15% are from 1.5.3. More detailed info are like below In latest 3 days, usage of 1.6+ increased to 80% but we still have 10% from 1.5.3. I'll keep an eye on the data in the following week but since our 0.3.x breaks quite often and there are still part of users are using Code 1.5.3 or even below, my personal suggestion about our Code engine upgrade is like
|
It looks like we'll be leaving about 15% of users behind. Seems like a large percentage, but in the 4-day span between the 2 graphs, 1/4 of those people upgraded (it went from 20.2% to 14.8%). FWIW, I'm fine with leaving these people behind, but that release plan sounds like the "safer" thing to do :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Easy suggestion: Show some sort of error dialog if the user is not on 1.6.0. Then we can merge this whenever. |
Yay! We love PRs! 🎊
Please include a description of your change and ensure:
gulp
)