Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post 1.0] Two way syncing of Vim and Code's configuration #913

Merged
merged 7 commits into from
Nov 2, 2016

Conversation

rebornix
Copy link
Member

Yay! We love PRs! 🎊

Please include a description of your change and ensure:

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

@rebornix rebornix force-pushed the ConfigAPI branch 2 times, most recently from e67a494 to d1d4d39 Compare October 14, 2016 22:23
@rebornix rebornix closed this Oct 14, 2016
@rebornix rebornix reopened this Oct 14, 2016
@rebornix
Copy link
Member Author

@johnfn @xconverge

With this PR, you should be able to manage configs through EX command and if it has overlap with Code, Code's configuration will be override and the new config will be stored in user's setting.json file.

Besides, it requires Code 1.6. Please let me know when do you think is the best time to merge it.

@johnfn
Copy link
Member

johnfn commented Oct 17, 2016

So this will actually directly update the user's settings.json if they do something like :set blah=true? That's really cool! Maybe we should prompt the user first (they might not expect that).

I'm otherwise fine to merge this! You guys are the ones with stats about 1.6 percentage usage after all. 😉

@rebornix
Copy link
Member Author

rebornix commented Oct 17, 2016

@johnfn @xconverge @jpoon

We've released Code 1.6 for a week and within these 7 days, 75% of the extension activations are from Code 1.6+, 15% are from 1.5.3. More detailed info are like below

image

In latest 3 days, usage of 1.6+ increased to 80% but we still have 10% from 1.5.3.

image

I'll keep an eye on the data in the following week but since our 0.3.x breaks quite often and there are still part of users are using Code 1.5.3 or even below, my personal suggestion about our Code engine upgrade is like

  • Have selection related bug fix merged and have a new release. Target 1.5
  • Have Macro merged and have a RC release. Still target 1.5
  • Wait for issues and feedback about selection or macro or anything else. Fix them and once it's stable, have our RTM release: 1.0
  • Have this PR merged and target 1.6+ for all following releases.

@jpoon
Copy link
Member

jpoon commented Oct 17, 2016

It looks like we'll be leaving about 15% of users behind. Seems like a large percentage, but in the 4-day span between the 2 graphs, 1/4 of those people upgraded (it went from 20.2% to 14.8%).

FWIW, I'm fine with leaving these people behind, but that release plan sounds like the "safer" thing to do :)

@rebornix rebornix mentioned this pull request Oct 18, 2016
3 tasks
@rebornix rebornix changed the title Two way syncing of Vim and Code's configuration [Post 1.0] Two way syncing of Vim and Code's configuration Oct 18, 2016
Copy link
Member

@jpoon jpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@johnfn
Copy link
Member

johnfn commented Oct 22, 2016

Easy suggestion: Show some sort of error dialog if the user is not on 1.6.0. Then we can merge this whenever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants