Improve Pair Matching Logic to Skip Parentheses Inside Strings #9370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linting removed pairing for grave accent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the logic behind parentheses pair matching. Currently, the logic does not ignore parentheses within quotations (i.e.
""or''). As a result, this leads to incorrect jump behaviour when users expect to skip parentheses within strings rather than treating them as matching pairs. This also consistent with Vim's actual logic.Current behaviour (using the
%command to jump to the next matching pair):current.mov
Fixed behaviour:
after.mov
Vim's actual behaviour:
vim.mov
Which issue(s) this PR fixes
Addresses: #9344
Special notes for your reviewer: