Fix replace in visual, visual line, and visual block mode #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xconverge
commented
Oct 20, 2016
| @@ -192,6 +192,41 @@ export class Position extends vscode.Position { | |||
| } | |||
|
|
|||
| /** | |||
| * Iterate over every position in the selection defined by the two positions passed in. | |||
| */ | |||
| public static *IterateSelection(topLeft: Position, bottomRight: Position): Iterable<{ line: string, char: string, pos: Position }> { | |||
There was a problem hiding this comment.
I have a feeling this exists somehow already?
There was a problem hiding this comment.
I am not using it anymore but I will leave it since it seems handy
xconverge
commented
Oct 20, 2016
| @@ -1366,6 +1366,9 @@ export class ModeHandler implements vscode.Disposable { | |||
| Position.EarlierOf(start, stop).getLineBegin(), | |||
| Position.LaterOf(start, stop).getLineEnd() | |||
| ) ]; | |||
| vimState.cursorStartPosition = selections[0].start as Position; | |||
There was a problem hiding this comment.
This is updating cursor positions correctly for visual line mode
xconverge
changed the title
…le iterating over every character, it was very slow.
rebornix
reviewed
Oct 25, 2016
| canBeRepeatedWithDot = true; | ||
|
|
||
| public async exec(position: Position, vimState: VimState): Promise<VimState> { | ||
| const toInsert = this.keysPressed[1]; |
rebornix
reviewed
Oct 25, 2016
| let end = vimState.cursorPosition; | ||
|
|
||
| // If selection is reversed, reorganize it so that the text replace logic always works | ||
| if (start.line > end.line || ((start.line === end.line) |
There was a problem hiding this comment.
I think we have start.isBeforeOrEqual(end)
rebornix
reviewed
Oct 25, 2016
| // If selection is reversed, reorganize it so that the text replace logic always works | ||
| if (start.line > end.line || ((start.line === end.line) | ||
| && (start.character > end.character))) { | ||
| let tmp = start; |
There was a problem hiding this comment.
you may like the syntax sugar [start, end] = [end, start]
There was a problem hiding this comment.
Ah dang, @johnfn guided me to this within the past month... will do
Fix test for visual line with typo Pull request feedback incorporated.
|
Should be good to go now thanks for the EOL find @Platzer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any feedback on better ways of doing any of this?
an IterateSelection position functionselective replace transforms in chunks