Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commands is s and S in visual block mode. #954

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Add commands is s and S in visual block mode. #954

merged 1 commit into from
Oct 20, 2016

Conversation

kyfk
Copy link
Contributor

@kyfk kyfk commented Oct 20, 2016

Yay! We love PRs! 🎊

Add commands is s and S in visual block mode.

10-20-2016 13-52-28

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp)

More info can be found on our contribution guide.

@rebornix
Copy link
Member

wow, this PR is amazing @johnfn

@johnfn
Copy link
Member

johnfn commented Oct 20, 2016

It's beautiful!

Only suggestion: make keys = [["S"], ["s"]] (which allows either sequence to trigger the action) in the first class, and remove the second class entirely.

@kyfk
Copy link
Contributor Author

kyfk commented Oct 20, 2016

https://github.com/VSCodeVim/Vim/pull/954/files#diff-7addcd1a8a241060a73b1fe4abb39960R3861

I fixed! ok?? @johnfn

@johnfn
Copy link
Member

johnfn commented Oct 20, 2016

Yup! :) Thanks for the PR, @kooooya!

@johnfn johnfn merged commit 4a8e3c3 into VSCodeVim:master Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpoon jpoon jpoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyfk @rebornix @johnfn @jpoon