Fix: Preserve view and pin preview tabs on :w #9818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccheesy
force-pushed
the
fix/preserve-diff-view-on-write
branch
from
37a6cba to
ab01c42
Compare
J-Fields
reviewed
Nov 7, 2025
J-Fields
reviewed
Nov 7, 2025
J-Fields
reviewed
Nov 7, 2025
J-Fields
reviewed
Nov 7, 2025
- Use Tab API when available to detect preview tabs and only call showTextDocument when needed. - Ensure saving in compare/diff editors does not switch to a normal editor (fixes VSCodeVim#9800, VSCodeVim#9796). - Keep previous behavior of pinning preview tabs on :w so :w matches Cmd+S (fixes VSCodeVim#9697). - Add test coverage for write, including new doc handling logic references PR VSCodeVim#9698 fixes VSCodeVim#9800, fixes VSCodeVim#9796, fixes VSCodeVim#9697
mccheesy
force-pushed
the
fix/preserve-diff-view-on-write
branch
from
ab01c42 to
65ba2ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references PR #9698
fixes #9800, fixes #9796, fixes #9697
Special notes for your reviewer: Copilot helped with this so if there are any style or coding conventions that I should adjust, I'm happy to update.