Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insiders Build? #148

Closed
Zate opened this issue May 5, 2019 · 23 comments · Fixed by #1217
Closed

Insiders Build? #148

Zate opened this issue May 5, 2019 · 23 comments · Fixed by #1217

Comments

@Zate
Copy link

Zate commented May 5, 2019

Any chance you'd be willing to do an insiders build also? Be handy for checking out / using new things without having to wait for it to hit regular vscodium, or having to revert back to vscode insiders to use it.

@pavanagrawal123
Copy link
Contributor

@stripedpajamas I think this is pretty reasonable to do, nightly builds could be adopted. Only issue is the release page getting cluttered with extra releases.

@stripedpajamas
Copy link
Member

I was thinking of making a new repo vscodium-insiders with a build script that clones this repo but builds with an env var that drops us into insider conditionals. I think it's very reasonable and we can do it for sure.

@lsmoura
Copy link

lsmoura commented May 14, 2019

@stripedpajamas Do you know where I can find these "insider conditionals"?

Currently I'm building vscodium every night from vscode's master branch and using it...

@stripedpajamas
Copy link
Member

We haven't written the conditionals yet. I think we will need to wrap the current logic of checking out the latest tag.

@lsmoura
Copy link

lsmoura commented May 14, 2019

@stripedpajamas Can we use the green icon here for the insiders version?

@stripedpajamas
Copy link
Member

Sounds good to me @lsmoura

@DanyC97
Copy link

DanyC97 commented May 31, 2019

@stripedpajamas any progress with the insiders build ? asking because i'd love to give https://code.visualstudio.com/blogs/2019/05/02/remote-development a try and see if it improves my productivity

@pavanagrawal123
Copy link
Contributor

@DanyC97 Even if insider builds were done, the licensing around all the new remote stuff is very closed off, and not going to be fun getting to work on oss builds.

@DanyC97
Copy link

DanyC97 commented Jun 4, 2019

oh i see @pavanagrawal123 , wasn't aware of that. Thx for taking the time to respond 👍

@stripedpajamas
Copy link
Member

Am not sure which approach to take here:

  1. configure .travis.yml in vscodium-insiders repo that clones vscodium and runs through build process with quality=insider set
    • setup build to run on schedule (nightly)
    • requires adding duplicating the env vars from VSCodium build (such as GITHUB_TOKEN) so that build can run through as normal
    • might also require setting up a separate Azure Pipeline config file as well (unclear)
  2. add linux/mac/windows builds to the vscodium travis and azure build matrices with quality=insider
    • vscodium already builds daily (could set time to make sure it builds at around the same time MS builds)
    • no duplicating build config (env vars etc)
    • downside is that if insider build fails, the readme badge will show build: failing. perhaps a small price to pay, and should only show for a day.

I am leaning toward option 2.

common work (when quality=insider):

  • checkout master instead of latest tag
  • change destination for release upload to vscodium-insiders repo (so as not to muddle vscodium releases page)
  • construct version of binary using package.json instead of tag (since no tag will exist)
  • add insider support to update-api and the version json update logic in the build process
  • copy over insider resources before build (this would cover insider-only icon)

@stripedpajamas
Copy link
Member

Additionally, it doesn't look like Travis's default deploy tool (which we are currently using) supports uploading releases to a different repo than then the one the build is running on.

So either we do option 1 above or use a different deploy tool with option 2.

@shreyasminocha
Copy link

it doesn't look like Travis's default deploy tool (which we are currently using) supports uploading releases to a different repo than then the one the build is running on.

I suppose GitHub Actions changes this.

@vraravam
Copy link

vraravam commented Dec 3, 2019

I would also very much to get such an insiders build - since I am on vscode-insiders - and the only reason I am unwilling to switch over to codium is the absence of the nightlies.

@nezia1
Copy link

nezia1 commented May 27, 2020

I would also very much to get such an insiders build - since I am on vscode-insiders - and the only reason I am unwilling to switch over to codium is the absence of the nightlies.

I'm exactly the same. How hard would it be to have it working?

@PF4Public
Copy link
Contributor

They seem to be using a hidden VSCODE_MIXIN_REPO for insiders.

@officialpiyush
Copy link

Any updates on Vscodium Insider Edition? 👀

@GitMensch
Copy link
Collaborator

Finally implemented with #1217 - binaries available with https://github.com/VSCodium/vscodium-insiders/releases; the build scripts (and workflows) are directly used from this repo (in case someone wants to use it to build an own insider version from "vscode" sources).

Congrats and thanks go to @daiyam!

@daiyam
Copy link
Member

daiyam commented Aug 30, 2022

(in case someone wants to use it to build an own insider version from "vscode" sources).

The section Insider will explain you how to do it.

@GitMensch
Copy link
Collaborator

@paulcarroty Using apt with the registered repositories does not bring up any insider version - could you add that, please?

@paulcarroty
Copy link
Collaborator

Done.

@GitMensch
Copy link
Collaborator

Thanks for codium-insiders!

@jcasale
Copy link

jcasale commented Nov 8, 2022

The insider releases seem to lag behind vscode, yet the workflows appear to run (they just don't find changes).

Are there still issues to work out or is something temporarily awry?

@daiyam
Copy link
Member

daiyam commented Nov 8, 2022

No, it's failing due to the need of updated patch:
https://github.com/VSCodium/vscodium/actions/runs/3417106561/jobs/5687898282

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.