Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Icon #4

Closed
ryanolsonx opened this issue Aug 27, 2018 · 43 comments · Fixed by #25
Closed

Better Icon #4

ryanolsonx opened this issue Aug 27, 2018 · 43 comments · Fixed by #25
Labels
discussion could go either way, discussion welcome

Comments

@ryanolsonx
Copy link

We should come up with a better icon for the FOSS version. The FOSS icon is really ugly. That would be sugar on top of the cake. 👍

@Breakthrough
Copy link

Breakthrough commented Aug 28, 2018

Here's my go at a logo which looks alright as an icon (see attached). Feel free to use it (or not) in any way you would like.

vscodium-logo-32x32
vscodium-logo-64x64
vscodum-logo

Source vector for branches/tree can be found here.

@stripedpajamas stripedpajamas added the enhancement New feature or request label Sep 4, 2018
@stripedpajamas
Copy link
Member

Thank you so much for this contribution, @Breakthrough

@ryanolsonx I also agree the current icon sucks. I'm a little wary of changing too much of original source repo during build because I want to keep trust levels high. But I think updating the icon shouldn't be too crazy, if it can be done in a very straightforward way. PRs are welcome. I'll do it if I can get some free time in the coming days.

@jaredreich
Copy link
Contributor

Not sure if this is too close to the original, but here's one I've used before to replace the original MS ones, which I think are ugly.
vscodium.icns.zip
vscodium

@solie
Copy link

solie commented Sep 27, 2018

something like code ninja :D
codium_logo
sample:
screenshot from 2018-09-27 21-26-44

@clarsonneur
Copy link
Contributor

clarsonneur commented Sep 29, 2018

Hi,

I can create a PR with one of proposal. My preference is the green one...

Following the OSS icon Commit on vscode, it seems to be simple. I will check and try.

I will need to find a way to generate from linux the png, the other format. If you have hint on this. I believe I know how to create the ico. but the icns...

@clarsonneur
Copy link
Contributor

Proposed this code change...

@stripedpajamas
Copy link
Member

Thank you for the PR @clarsonneur

To anyone involved in this discussion, here are my thoughts:

  • The current MS icon sucks
  • Three icons have been proposed, so I think it comes down to how many 👍 each gets to decide
  • The gorgeous icon proposed by @jaredreich I believe would be considered a copyright violation for us to use as it is nearly identical to the Visual Studio icon (reference). I don't want any possibility of copyright problems so I'm not considering that icon (unless anyone can show that it would be safe).
  • The most 👍 s would then fall to the tree icon submitted by @Breakthrough, which @clarsonneur has kindly put a PR in for (Better oss icon #25)

I am inclined to merge this PR but I wanted to make sure everyone has a chance to speak up if they have any hesitations about this.

@jaredreich
Copy link
Contributor

@stripedpajamas I agree about the potential copyright issues. I think the tree icon is aiming to look like "codium" which is a type of algae, but yeah it looks more a standard tree. I'll post another set of icons shortly.

@vforge
Copy link

vforge commented Oct 2, 2018

@jaredreich You can hardly recognize the tree in the very small icon (not to mention the leaves and branches are not visible at all). I suggest using a simpler, more geometric icon (or tree/algae representation).

@jaredreich
Copy link
Contributor

What do y'all think? (.icns files are in the .zip file below)

codium.zip

@sam0x17
Copy link

sam0x17 commented Oct 3, 2018

is it bad that I love the ms icon?

@Jorgeelalto
Copy link

Jorgeelalto commented Oct 3, 2018

What do y'all think? (.icns files are in the .zip file below)

codium.zip

Definitely much better @jaredreich , keeps the current logo trend of flat with gradients but integrates the previous idea of a tree with leaves. For me it's the best one

@clarsonneur
Copy link
Contributor

Great. To be honest, I prefer when we have few colors. It is quite monochrome icon. But I'm ok.
I can update the PR with those icons.

@Jorgeelalto
Copy link

Well, to be honest being a monochrome icon you can change the gray to any other dark shaded colour and it will work nice. Maybe we can try with green or blue?

@clarsonneur
Copy link
Contributor

Sure. Let's make a try.

@Jorgeelalto
Copy link

export

Hey, this is a quick test with some colors. Personally I like the light and dark blue, and the light green, because the dark green is too similar to Atom. The orange ones were just a test and I don't really think they fit too well. Note that I call "dark" to the colour filled ones with the white tree, and "light" the ones which are white with the colored tree.

colored.zip

@clarsonneur
Copy link
Contributor

I vote for green one! :-)

@stripedpajamas stripedpajamas added discussion could go either way, discussion welcome and removed enhancement New feature or request labels Oct 3, 2018
@jaredreich
Copy link
Contributor

Let's not use green only because of one person's opinion. For me, I liked grey because it doesn't associate with any brand and implies plain and clean.

A vote would make sense here.

image

👍 - grey
😄 - green
🎉 - blue
❤️ - other

@stripedpajamas
Copy link
Member

@jaredreich it looks like blue has beat grey by a small margin. Maybe we give it one more day and then move forward?

I am curious, regardless of which one is voted in, are we using the colored-background-white-logo or the white-background-colored-logo? Another vote?

@jaredreich
Copy link
Contributor

jaredreich commented Oct 4, 2018

New vote:

image

Whatever the result, here are all the assets (including sketch file):
codium_icons.zip

👍 - light blue
🎉 - dark blue

@stripedpajamas
Copy link
Member

@clarsonneur can you update your PR with the voted for icon?

@stripedpajamas
Copy link
Member

Upon a little investigation of the vscode repo, it looks like we need quite a few more files if we are going to replace the existing icon.

  • a few weeks ago MS merged in custom icons for a lot of the major file types, all of which include a tiny version of the current OSS icon in the corner 😱 See the darwin icon folder and the win32 icon folder for what I mean
  • the win32 folder also includes two bitmaps with the OSS icon for use in the windows installer (big and small), a 150x150 png of the current icon, and a 70x70 png of the current icon
  • the linux icon set is still just the one png file 🙌 so I guess the many file type icon set is not going to apply to that OS
  • there are three "letterpress" svgs in the main resources folder, all of which are variations of the current icon. I don't know where this is used, but it would be safest to replace them as well if we move forward

Leaving it up to the community to decide if the current MS icon is ugly enough to warrant the work necessary to swap it out 🆘

cc @jaredreich

@Jorgeelalto
Copy link

The custom icon set for every file type is a bit more of work but it's certainly feasible. I would not mind working on that to be honest, but maybe we can focus on the linux icon set, the win32 icons for the installer (and the 150x & 70x versions). I think we can easily generate those from the original files by @jaredreich :)

@jaredreich
Copy link
Contributor

You should be able to generate everything you need from the sketch file I uploaded. I think a nice icon is pretty important if you want anyone to use this app.

@stripedpajamas are you not able to do this, being the original contributor?

@stripedpajamas
Copy link
Member

I would do it but I don't know how. Anyone with more expertise with icons can help out here. Thank you @jaredreich for all the work so far 🙏

@clarsonneur
Copy link
Contributor

@stripedpajamas Yes, I will update the PR.

@clarsonneur
Copy link
Contributor

@jaredreich @stripedpajamas, I reworked on the PR, but I'm in trouble to generate icns files...

The only thing I can do, is to convert png to icns (from linux)
But, doing that way, I got an icns file with a single icon, while vscode has multiple icons for each icns file.

I tried https://iconverticons.com/online/ to convert ico files to icns, or from png.
But, doing that way, I got a HQX file format, where I can't extract the icns.
I tried the macutils to extract the resource file, but then... I don't know how to extract the icns from that resource file (*.RSRC).

I'm currently blocked here.
Any help or hint would be appreciate to move further...

@jaredreich
Copy link
Contributor

@clarsonneur
Copy link
Contributor

I'm under Linux. So, the first one won't work.

I tried the second one, but I did not used properly. I retried and it looks good! So, thanks, I will use that one!

@paulcarroty
Copy link
Collaborator

This issue was created 43 days ago. Maybe it's time to speed up slowly? 😄

@clarsonneur Photoshop 2018 works great under wine.

@clarsonneur
Copy link
Contributor

@paulcarroty Thanks for the suggestion. I have wine for a while, but I avoid it... usually it is not well working for different unknown reason. So, I prefer to avoid.

Anyway, the last website is the right one to fix the latest issue for mac. And then it will be done. normally today.

@clarsonneur
Copy link
Contributor

The PR is ready

I have a doubt about the icns file.
I was able to create each for same image format (256/512) in single files from several png files, but it looks like transparency has been lost.

I used the png2icns which finally do a better job than https://cloudconvert.com/png-to-icns
I reworked all vscode icons.

I thought to expose the code to generate them from a script. But I don't know if that make sense for you guys.
Anyway, I think we have all to go forward now.

@paulcarroty
Copy link
Collaborator

@clarsonneur I checked the 3 or 4 your icons - no issues.

stripedpajamas pushed a commit that referenced this issue Oct 11, 2018
@stripedpajamas
Copy link
Member

Thanks for everyone's help and discussion to get this wrapped up! 🙏

I will rebuild release 1.28.0 and update homebrew so new downloads get the new icon.

@rm--
Copy link

rm-- commented Oct 12, 2018

Looks very cool! Thanks to all of you.

@harvest316
Copy link

Sorry, still pretty garish compared to other icons. Way to complex. Need something simpler like @jaredreich 's original suggestion, just reimagined so it doesn't break copyright. #4 (comment)

@harvest316
Copy link

harvest316 commented Apr 24, 2019

Here's a Windows PowerShell script to set your VSCodium icon to anything you like. Just stick the icon in the same folder as this script, and call it VSCodium.ico

Write-Host "`n========= Setting VSCodium Icon ========="
#Here's a Windows PowerShell script to set your VSCodium icon to anything you like.
#Just stick the icon in the same folder as this script, and call it VSCodium.ico
#It presumes your install path for VSCodium is the default.  If not, change the 3rd last line.

#region Header
$debugMode = $false
if ($debugMode) { 
    Set-PSDebug -Step -Trace 2
} else {
    $ErrorActionPreference = 'SilentlyContinue'
}
$here = Split-Path -parent $MyInvocation.MyCommand.Definition
$script = $MyInvocation.MyCommand.Name
#endregion

Write-Host "`n========= Ensure Elevated Privileges ========="
#region
$identity = [System.Security.Principal.WindowsIdentity]::GetCurrent()
$principal = New-Object System.Security.Principal.WindowsPrincipal($identity)
if (-not $principal.IsInRole([System.Security.Principal.WindowsBuiltInRole]::Administrator)) {
    Write-Warning "Not running with administrative rights. Attempting to elevate..."
    $command = "-NoProfile -ExecutionPolicy ByPass -Command `"$here\$script`""
    # Write-Host $command
    Start-Process powershell -verb runas -argumentlist $command
    Exit
}
#endregion

#And now for the guts of this script:
$Shell = New-Object -ComObject ("WScript.Shell")
$Shortcut = $Shell.CreateShortcut("$env:ProgramData\Microsoft\Windows\Start Menu\Programs\VSCodium\VSCodium.lnk")
$Shortcut.IconLocation = "$here\VSCodium.ico, 0"
$Shortcut.Save()

@bittner
Copy link
Contributor

bittner commented May 26, 2019

Just wanted to say a big, massive 🙇‍♂️ THANK YOU 💯 for the beautiful icon and VSCodium in general. This lightens up my day constantly. You girls and guys are all awesome! 🏅

@onetruffle
Copy link

Poor @Breakthrough.

@Avaray
Copy link

Avaray commented Oct 26, 2020

I agree that default icon of VSCodium is terrible.
Is there any reason for Not using official VSCode icon?

BTW. All icon proposals above are also terrible. Please, don't use any of them.

@sam0x17
Copy link

sam0x17 commented Oct 29, 2020

I think the codium_blue_dark one looks great. The white version is too bright though.

@bittner
Copy link
Contributor

bittner commented Oct 29, 2020

This is all a matter of the past. The new logo rocks. Face it! And seriously, really, it's not all that bad, is it?

Be. Good. Citizens!

@harvest316
Copy link

Much agreed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
unennhexium pushed a commit to unennhexium/vscodium that referenced this issue Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion could go either way, discussion welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.