Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VOTE] macOS BigSur app icon update #591

Closed
setanarut opened this issue Dec 20, 2020 · 18 comments · Fixed by #612
Closed

[VOTE] macOS BigSur app icon update #591

setanarut opened this issue Dec 20, 2020 · 18 comments · Fixed by #612

Comments

@setanarut
Copy link
Contributor

setanarut commented Dec 20, 2020

Will need a vote for big sur icons; will merge this as is for now.
Originally posted by @stripedpajamas in #582 (comment)

Before/After

codium_vote

I recommend the optimized version, there will be no visual difference.

ICNS file (629KB 1024x1024 144dpi Multiple size);
https://yadi.sk/d/mIlIdbAL2_gqpg

ICNS file (126KB 512x512 72dpi Optimized version);
https://yadi.sk/d/POI_637hLAgF0g

Yes 👍🏼
No 👎🏼

@setanarut setanarut changed the title Will need a vote for big sur icons; will merge this as is for now. Will need a vote for macOS BigSur app icon [VOTE] Dec 20, 2020
@setanarut setanarut changed the title Will need a vote for macOS BigSur app icon [VOTE] macOS BigSur app icon update [VOTE] Dec 20, 2020
@stripedpajamas stripedpajamas changed the title macOS BigSur app icon update [VOTE] [VOTE] macOS BigSur app icon update Dec 23, 2020
@stripedpajamas stripedpajamas pinned this issue Dec 23, 2020
This was referenced Dec 23, 2020
@h0adp0re
Copy link

Sorry, how do you mean Yes or No? In reference to what? Yes to what? No to what?

@stripedpajamas
Copy link
Member

@R0LA1mRifcF8yAkk Yes (:+1:) is a vote to change the VSCodium logo (for Mac users) to the blue square icon in the picture. No (:-1:) is a vote to leave the logo as is (white circle). Note that the latest release still has a green logo but that will change upon next release to logo at the top of the README.

@h0adp0re
Copy link

Right. Could there be more than just 1 alternative? How about one with white background but instead of the circle it'd have a square?

The blue background is an almost entirely different visual. Might be difficult to identify or get used to when OS-hopping.

@setanarut
Copy link
Contributor Author

white is too bright for dark mode. but blue is not too dark for light mode. are you designer?

@h0adp0re
Copy link

Well that's just the icon, not the whole app. I've plenty of light icons whilst using dark mode and I'm perfectly happy.

I once was a designer, yes. Is this relevant?

@setanarut
Copy link
Contributor Author

setanarut commented Dec 30, 2020

i dont like this codium tree icon. too detailed for an emblem. you can read old closed issues. i made this blue icon for dark mode users not for big sur or apple or vscodium

@meduzen
Copy link

meduzen commented Dec 30, 2020

white is too bright for dark mode. but blue is not too dark for light mode. are you designer?

Reverse opinion: white is too bright for light mode. There’s not enough contrast between the Dock and the icon background. 👼

image

It’s an icon in the Dock, and macOS doesn’t allow to have dual icons depending on the color scheme, so it should not be a criteria to dismiss or validate an app icon.

@setanarut
Copy link
Contributor Author

Let’s Do Science! - WCAG contrast check.

My new blue emblem

  • White tree on blue - PASS
  • Blue background on light background - PASS
  • Blue background on dark background - PASS

Current round emblem.

  • Cyan color of tree gradient on white circle - FAIL
    • Ekran Resmi 2020-12-30 14 05 56
  • Blue color of tree gradient on white circle - PASS
  • White background on light background - FAIL
  • White background on dark background - PASS ( too bright for eyes )

@h0adp0re
Copy link

h0adp0re commented Dec 31, 2020

Reverse opinion: white is too bright for light mode. There’s not enough contrast between the Dock and the icon background. 👼

You can still see the icon itself, which is the important part, as opposed to the background. Apple has made a couple of similar icons, on Big Sur – Pages and Reminders. The background is white and the relevant part of the icon is very noticeable.

Let’s Do Science! - WCAG contrast check.

The contrast checker tool is intended for text and UI icons. Neither of which is being discussed here.

@h0adp0re
Copy link

[...] macOS doesn’t allow to have dual icons depending on the color scheme [...]

Seeing as this is true, is this issue still valid?

The only merit this issue could provide, would be to provide the users with an alternate icon, as has been done before (#4, #472). A user has even created a small script for simpler substitution.

@stripedpajamas
Copy link
Member

The vote looks pretty decisive and has been open for about a month. I will approve/merge a PR that replaces the Mac OS icon with the proposed icon.

@setanarut
Copy link
Contributor Author

my related proposal #616

@paulcarroty
Copy link
Collaborator

why this issue is still pinned?

@stripedpajamas stripedpajamas unpinned this issue Jan 25, 2021
@trankov
Copy link

trankov commented Feb 12, 2021

How to get back an old icon? This new one looks ugly and scaring for me. Sorry, but true ( Is there any way to do it?

@h0adp0re
Copy link

Hey @trankov, I believe you'll find what you need in #472.

It's a sad state of affairs when every few months a single user decides to change the logo (!) of the app and the many users who are opposed to the change, are left high and dry.

This vote went down just like the other one — without much publicity beforehand or during. Just the users visiting this repo's issues (!) were able to voice their opinion.

I've marked a couple of my thoughts with an exclamation mark to highlight why this complaint exists.

@trankov
Copy link

trankov commented Feb 13, 2021

Hello @R0LA1mRifcF8yAkk, thank you very much for your answer!
I'm absolutely fine with changing an icon manually with every update. It's a free soft, and developers spending their personal time. I'm far from criticise them. The only thing I need is to find the old green logo with the Mobius strip (is it a Mobius strip?) I have no idea where to looking for it. In history of commits maybe.

@h0adp0re
Copy link

@trankov it exists in the issues as well somewhere, search for "logo".

@trankov
Copy link

trankov commented Feb 13, 2021

@R0LA1mRifcF8yAkk
Thanks for advice, finally I've got it )
https://github.com/stripedpajamas/vscodium/raw/0a20f8159a5c6e29866a3df3b99c9bf84ff90fc9/src/resources/darwin/code.icns

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants