Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding #477

Closed
sefsh opened this issue Aug 19, 2020 · 10 comments
Closed

Branding #477

sefsh opened this issue Aug 19, 2020 · 10 comments
Labels
discussion could go either way, discussion welcome enhancement New feature or request

Comments

@sefsh
Copy link

sefsh commented Aug 19, 2020

First of all: nice to see a new logo. Good job!

I want to inquire about the choice of color. If we take a look at the first run experience, not only are we witnessing a clash between the blue UI color and the eyesore that is the default VSCode status bar, but now there's the VSCodium brand color slammed in there as well. The old logo harmonized completely with the blue UI color. What was the reasoning behind this choice?

bild

I also want to inquire about the empty screen logo variation. A flat version like this would need a counterpart for what the folding shadow does on the main logo.

bild

@sefsh sefsh added the bug Something isn't working label Aug 19, 2020
@jvdp
Copy link

jvdp commented Aug 20, 2020

Maybe mostly related to this issue (though I can make a new one if you like;) the logo color clashes / fades a bit with lighter colors behind it:

image

Subjectively, I do like the logo, though perhaps not so much the color. Objectively, a border around it (or some other adjustment) would perhaps make it fit in better.

@olivier-manomano
Copy link

I would add that it looks a bit oversized when sitting close to other rounded icons (at least in the dock of macOS Catalina).

Screenshot 2020-08-20 at 18 30 55

Regarding the color, I guess it's a matter of taste. But I also have the impression that it looks very bright on dark backgrounds, while it tends to fade away over grayish backgrounds.

Screenshot 2020-08-20 at 18 40 21

@viridiancity
Copy link

The previous logo was 1,000,000 times better than whatever this new one is.

@stripedpajamas stripedpajamas added discussion could go either way, discussion welcome enhancement New feature or request and removed bug Something isn't working labels Aug 21, 2020
@cd4d
Copy link

cd4d commented Aug 22, 2020

You can check #481 if you want a blue version of the new logo.

@sefsh
Copy link
Author

sefsh commented Aug 24, 2020

Honestly, now that I've image googled "codium" I really don't see why the old brand mark was discarded. It fits beautifully.

@indexerrowaty
Copy link

Imo older logo was WAY WAY better.

@sys-lectern
Copy link

I really like the new logo, and I think it helps to differentiate/set expectations for the experience since the extensions provider was changed.
I don't really care about the color, but the shape itself is pleasing.

@Eonfge
Copy link

Eonfge commented Aug 26, 2020

The new logo is bad because it's not resting on a background. This is a design feature of both Mac, Windows and Android style-guides, which can be found here:

The only noticeable exception is Linux, who by it's nature of free market competition has competing standards.

It's worth noting that GNOME doesn't care about backgrounds, but they do care about shapes, which is also nice to read about.

In the image posted by @olivier-manomano you can see how other applications follow the style guide on Mac.

What to do

Two options if you ask me

  • Revert the icon change
  • Change the current icon and add a background

Controversy?

In another issue (#472), the project leaders have stated that they don't want to make any changes which I think is dumb. This change is directly in conflict with multiple platform guides.

Bootnote
The icon might also really suck for colour blind people. I myself am near-sighted and without glasses, the new logo is less easy to recognize then the old logo.

@thijsvandien
Copy link

Here's how the new icon looks for me...

Screen Shot 2020-08-26 at 10 56 57

@stripedpajamas
Copy link
Member

Icon has been reverted (will be in next release). Meanwhile there's another vote to update the old icon to "Big Sur style" for Mac users in #591

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion could go either way, discussion welcome enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants