Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verilog parser invalid handling of whitespace can miss newlines #587

Closed
haggaie opened this issue Nov 19, 2019 · 2 comments
Closed

Verilog parser invalid handling of whitespace can miss newlines #587

haggaie opened this issue Nov 19, 2019 · 2 comments

Comments

@haggaie
Copy link

haggaie commented Nov 19, 2019

When parsing the `timescale command, the parser tries to skip until the end of the line. However, if the line ends with a whitespace, the tokenizer merges the whitespace and the new line, and consumes the next line. For example, this code can cause vunit to fail detecting the module:

`timescale 1ns / 1 ns 

module my_tb();
@kraigher
Copy link
Collaborator

Should be fixed on master now.

@haggaie
Copy link
Author

haggaie commented Nov 20, 2019

Works for me, thanks!

@haggaie haggaie closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants