Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify that GHDL is a rolling project #694

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Conversation

DeniTCH
Copy link
Contributor

@DeniTCH DeniTCH commented Nov 15, 2020

Added a note to clarify that GHDL is a rolling project and a recommendation to use the nightly version. Closes #691

Added a note to clarify that GHDL is a rolling project and a recommendation to use the nightly version. Closes VUnit#691
@@ -19,7 +19,7 @@ Simulators:
- `Aldec Active-HDL`_: Tested with Active-HDL 9.3, 10.1, 10.2, 10.3 (x64/x86)
- `GHDL`_

- Works with versions >= 0.33
- Works with versions >= 0.33 (Note: GHDL is a rolling project, it is therefore recommended to use the latest `nightly release`_ tarball.)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, write the URL inline:

`nightly release <https://github.com/ghdl/ghdl/releases/tag/nightly>`_

Also, you can write the Note as an admonition:

      -  Works with versions >= 0.33
         .. NOTE:: GHDL is a rolling project, it is therefore recommended to use the latest `nightly release <https://github.com/ghdl/ghdl/releases/tag/nightly>`_ tarball.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inlined the URL, as you suggested.

@eine eine changed the title Added a note to clarify that GHDL version docs: clarify that GHDL is a rolling project Nov 17, 2020
@eine eine merged commit 416db8a into VUnit:master Nov 17, 2020
@eine eine added the Docs label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with component binding when using component instantiation
2 participants