Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file viewer / web3.js and ethers.js upgrade #52

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

Huzitatuguharu
Copy link
Contributor

@Huzitatuguharu Huzitatuguharu commented Dec 8, 2023

NFTの実データ閲覧画面の修正

  • Image画像が大きいのでサイズの調整
  • PDFのページネーションをボタン要素に変更
     - ホバー時のCursor変更
     - Tabキー でフォーカスが当たるように変更
  • 何の画面かわかるようにView Dataをヘッダーに追記

image

ethers.js v5 から v6 へ

公式ドキュメント
https://docs.ethers.org/v6/api/providers/#BrowserProvider

@metamask/detect-providerのエラーがでたので、
window.ethereumを直接使用する方式に書き換えています。
同じようなissueがあがっていますが、解決方法なし
MetaMask/detect-provider#68

Web3.js v1 から v4 へ

公式ドキュメント
https://docs.web3js.org/guides/web3_upgrade_guide/x/

動作確認

NFTミント、NFT表示、NFTの転送、NFTの受け取り確認済み

ミント
https://mumbai.polygonscan.com/tx/0x13a2a80af6ec3428cb359f1471f5e6b490060bb83e2b8452ff8caa2ea2080a06

転送
https://mumbai.polygonscan.com/tx/0xec676043f97269801fe38b839d338417fb2c6ff95c761335433a7ff8a670fc5d

@Huzitatuguharu Huzitatuguharu changed the title fix: pdf viewer fix: file viewer Dec 11, 2023
@Huzitatuguharu Huzitatuguharu marked this pull request as ready for review December 15, 2023 01:07
Copy link
Contributor

@thashimoto1998 thashimoto1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
nagaiさんからのapproveの後にマージしてもらえると!

Copy link
Contributor

@wakoto3 wakoto3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Huzitatuguharu Huzitatuguharu changed the title fix: file viewer fix: file viewer web3js and ethers.js upgrade Dec 19, 2023
@Huzitatuguharu Huzitatuguharu changed the title fix: file viewer web3js and ethers.js upgrade fix: file viewer・web3js and ethers.js upgrade Dec 19, 2023
@Huzitatuguharu Huzitatuguharu changed the title fix: file viewer・web3js and ethers.js upgrade fix: file viewer・web3.js and ethers.js upgrade Dec 19, 2023
@Huzitatuguharu Huzitatuguharu changed the title fix: file viewer・web3.js and ethers.js upgrade fix: file viewer / web3.js and ethers.js upgrade Dec 19, 2023
@Huzitatuguharu Huzitatuguharu merged commit 8bdf749 into develop Dec 19, 2023
@Huzitatuguharu Huzitatuguharu deleted the fix/pdf-viewer branch December 19, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants