Integrating with autograd, adding static kernel routing.
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2024
| auto output_sizes = input_sizes.vec(); | ||
| output_sizes.pop_back(); | ||
| output_sizes.push_back(-1); | ||
| auto output = flat_output.view(output_sizes); | ||
| auto output = flat_output.reshape(output_sizes).clone(); |
There was a problem hiding this comment.
Can you please briefly describe why does this need clone on top of reshape?
There was a problem hiding this comment.
RuntimeError: Output 0 of _QuantizedMatmulBackward is a view and is being modified inplace. This view was created inside a custom Function (or because an input was returned as-is) and the autograd logic to handle view+inplace would override the custom backward associated with the custom Function, leading to incorrect gradients. This behavior is forbidden. You can fix this by cloning the output of the custom Function.There was a problem hiding this comment.
I added .clone() because the machine told me to.
There was a problem hiding this comment.
In Machine we trust!
justheuristic
approved these changes
Feb 20, 2024
Co-authored-by: justheuristic <justheuristic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to: