Skip to content

Commit

Permalink
Merge pull request #450 from ValeevGroup/evaleev/fix/eigen3-ep-tmpdir
Browse files Browse the repository at this point in the history
`ExternalProject_Add` avoids touching install directory at configure time
  • Loading branch information
evaleev authored Apr 3, 2024
2 parents 8737c91 + 5e22878 commit e26379a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions external/eigen.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,10 @@ else()
message("** Will build Eigen from ${EIGEN3_URL}")

ExternalProject_Add(eigen3
PREFIX ${CMAKE_INSTALL_PREFIX}
#--Download step--------------
PREFIX ${FETCHCONTENT_BASE_DIR}
STAMP_DIR ${FETCHCONTENT_BASE_DIR}/eigen3-ep-artifacts
TMP_DIR ${FETCHCONTENT_BASE_DIR}/eigen3-ep-artifacts # needed in case CMAKE_INSTALL_PREFIX is not writable
#--Download step--------------
DOWNLOAD_DIR ${EXTERNAL_SOURCE_DIR}
URL ${EIGEN3_URL}
URL_HASH ${EIGEN3_URL_HASH}
Expand Down
2 changes: 1 addition & 1 deletion external/librett.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ else()
message(STATUS "custom target librett is expected to build these byproducts: ${LIBRETT_BUILD_BYPRODUCTS}")

ExternalProject_Add(librett
PREFIX ${CMAKE_INSTALL_PREFIX}
PREFIX ${FETCHCONTENT_BASE_DIR}
STAMP_DIR ${FETCHCONTENT_BASE_DIR}/librett-ep-artifacts
TMP_DIR ${FETCHCONTENT_BASE_DIR}/librett-ep-artifacts # needed in case CMAKE_INSTALL_PREFIX is not writable
#--Download step--------------
Expand Down
2 changes: 1 addition & 1 deletion external/umpire.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ else()
message(STATUS "custom target Umpire is expected to build these byproducts: ${UMPIRE_BUILD_BYPRODUCTS}")

ExternalProject_Add(Umpire
PREFIX ${CMAKE_INSTALL_PREFIX}
PREFIX ${FETCHCONTENT_BASE_DIR}
STAMP_DIR ${FETCHCONTENT_BASE_DIR}/umpire-ep-artifacts
TMP_DIR ${FETCHCONTENT_BASE_DIR}/umpire-ep-artifacts # needed in case CMAKE_INSTALL_PREFIX is not writable
#--Download step--------------
Expand Down

0 comments on commit e26379a

Please sign in to comment.