CMake: Use GNUInstallDirs variables instead of hard-coded paths #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeLists.txt
Outdated
| @@ -78,19 +78,19 @@ enable_language(C) # C needed even for basic platform introspection | |||
|
|
|||
| # Set install paths ============================================================ | |||
|
|
|||
| set(TILEDARRAY_INSTALL_BINDIR "bin" | |||
| set(TILEDARRAY_INSTALL_BINDIR "${CMAKE_INSTALL_BINDIR}" | |||
There was a problem hiding this comment.
These should come after include(GNUInstallDirs)
There was a problem hiding this comment.
Thanks, I moved the set of install paths into the place after include(GNUInstallDirs)
There was a problem hiding this comment.
@evaleev would have to comment on whether TILEDARRAY_INSTALL_XYZ need to be set before include-ing the TA-specific CMake modules.
There was a problem hiding this comment.
it appears that currently TILEDARRAY_INSTALL_* vars are not used by files in cmake/modules but were used in the past. So keeping the original location of the definitions of TILEDARRAY_INSTALL_* would be ideal.
Thanks, @topazus !
evaleev
approved these changes
Sep 15, 2023
This was referenced Oct 18, 2023
Merged
This was referenced Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CMake practice suggests the variables in
GNUInstallDirsto be used for the installation paths. The hard-coded paths should be avoided.Ref: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
https://cmake.org/cmake/help/latest/command/install.html