Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Svelte 5 runes support #59

Merged
merged 12 commits into from
Jan 13, 2025
Merged

Add Svelte 5 runes support #59

merged 12 commits into from
Jan 13, 2025

Conversation

rtrampox
Copy link
Contributor

Refactor code in favor of new svelte 5 runes syntax.

  • Upgrade svelte and its dependencies to the latest version.
  • Add CropperProps type that describes all the component props.
  • Update $ syntax to $effect() and $state() for runes mode support.

Copy link

socket-security bot commented Dec 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@esbuild/aix-ppc64@0.24.0 None 0 11.2 MB evanw
npm/@esbuild/android-arm@0.24.0 None 0 11.9 MB evanw
npm/@esbuild/android-arm64@0.24.0 None 0 10.6 MB evanw
npm/@esbuild/android-x64@0.24.0 None 0 11.9 MB evanw
npm/@esbuild/darwin-arm64@0.24.0 None 0 9.75 MB evanw
npm/@esbuild/darwin-x64@0.24.0 None 0 10.4 MB evanw
npm/@esbuild/freebsd-arm64@0.24.0 None 0 9.5 MB evanw
npm/@esbuild/freebsd-x64@0.24.0 None 0 10.2 MB evanw
npm/@esbuild/linux-arm@0.24.0 None 0 9.63 MB evanw
npm/@esbuild/linux-arm64@0.24.0 None 0 9.57 MB evanw
npm/@esbuild/linux-ia32@0.24.0 None 0 9.59 MB evanw
npm/@esbuild/linux-loong64@0.24.0 None 0 9.77 MB evanw
npm/@esbuild/linux-mips64el@0.24.0 None 0 10.9 MB evanw
npm/@esbuild/linux-ppc64@0.24.0 None 0 9.83 MB evanw
npm/@esbuild/linux-riscv64@0.24.0 None 0 9.44 MB evanw
npm/@esbuild/linux-s390x@0.24.0 None 0 10.7 MB evanw
npm/@esbuild/linux-x64@0.24.0 None 0 10.2 MB evanw
npm/@esbuild/netbsd-x64@0.24.0 None 0 10.1 MB evanw
npm/@esbuild/openbsd-arm64@0.24.0 None 0 9.57 MB evanw
npm/@esbuild/openbsd-x64@0.24.0 None 0 10.2 MB evanw
npm/@esbuild/sunos-x64@0.24.0 None 0 10.2 MB evanw
npm/@esbuild/win32-arm64@0.24.0 None 0 9.57 MB evanw
npm/@esbuild/win32-ia32@0.24.0 None 0 9.85 MB evanw
npm/@esbuild/win32-x64@0.24.0 None 0 10.4 MB evanw
npm/@jridgewell/gen-mapping@0.3.8 None 0 0 B
npm/@jridgewell/set-array@1.2.1 None 0 17.9 kB jridgewell
npm/@jridgewell/sourcemap-codec@1.5.0 None 0 113 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.25 None 0 169 kB jridgewell
npm/@rollup/rollup-android-arm-eabi@4.29.1 None 0 1.61 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-android-arm64@4.29.1 None 0 2.23 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-darwin-arm64@4.29.1 None 0 2.21 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-darwin-x64@4.29.1 None 0 2.37 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-freebsd-arm64@4.29.1 None 0 2.13 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-freebsd-x64@4.29.1 None 0 2.46 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm-gnueabihf@4.29.1 None 0 2.24 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm-musleabihf@4.29.1 None 0 2.24 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm64-gnu@4.29.1 None 0 2.22 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm64-musl@4.29.1 None 0 2.11 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-loongarch64-gnu@4.29.1 None 0 2.56 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-powerpc64le-gnu@4.29.1 None 0 2.76 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-riscv64-gnu@4.29.1 None 0 2.26 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-s390x-gnu@4.29.1 None 0 3.83 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-x64-gnu@4.29.1 None 0 2.5 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-x64-musl@4.29.1 None 0 2.48 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-arm64-msvc@4.29.1 None 0 2.74 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-ia32-msvc@4.29.1 None 0 2.58 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-x64-msvc@4.29.1 None 0 3.29 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@sveltejs/kit@2.15.0 None +1 849 kB conduitry, dominik_g, rich_harris, ...1 more
npm/@sveltejs/package@2.3.7 None 0 29.1 kB svelte-admin
npm/@sveltejs/vite-plugin-svelte-inspector@4.0.1 Transitive: environment +1 68.7 kB svelte-admin
npm/@sveltejs/vite-plugin-svelte@5.0.3 None 0 126 kB conduitry, dominik_g, rich_harris, ...1 more
npm/@types/estree@1.0.6 None 0 25.8 kB types
npm/acorn-typescript@1.4.13 None 0 532 kB tyrealhu
npm/acorn@8.14.0 None 0 547 kB marijn
npm/aria-query@5.3.2 None 0 176 kB ljharb
npm/axobject-query@4.1.0 None 0 111 kB ljharb
npm/chokidar@4.0.3 None 0 149 kB paulmillr
npm/devalue@5.1.1 None 0 31.8 kB rich_harris
npm/esbuild@0.24.0 environment, filesystem, network, shell 0 134 kB evanw
npm/esm-env@1.2.1 None 0 3.94 kB benmccann
npm/esrap@1.3.2 None 0 48.7 kB rich_harris
npm/is-reference@3.0.3 None 0 3.95 kB rich_harris
npm/magic-string@0.30.17 None 0 467 kB alangpierce, antfu, mourner, ...1 more
npm/ms@2.1.3 None 0 6.72 kB styfle
npm/prettier-plugin-svelte@3.3.2 environment 0 1.5 MB dummdidumm
npm/prettier@3.4.2 None 0 7.83 MB prettier-bot
npm/readdirp@4.0.2 filesystem 0 32.2 kB paulmillr
npm/rollup@4.29.1 None 0 2.61 MB eventualbuddha, lukastaegert, rich_harris, ...2 more
npm/sirv@3.0.0 None 0 21.8 kB lukeed
npm/svelte@5.15.0 None 0 2.47 MB conduitry, rich_harris, svelte-admin
npm/svelte2tsx@0.7.31 None 0 758 kB svelte-language-tools-deploy
npm/vite@6.0.5 Transitive: environment, filesystem +3 3.16 MB antfu, patak, soda, ...2 more
npm/vitefu@1.0.4 None 0 20.8 kB bluwy
npm/zimmerframe@1.1.2 None 0 12.3 kB rich_harris

🚮 Removed packages: npm/@jridgewell/gen-mapping@0.3.3, npm/@jridgewell/set-array@1.1.2, npm/@jridgewell/sourcemap-codec@1.4.15, npm/@rollup/rollup-android-arm-eabi@4.9.1, npm/@rollup/rollup-android-arm64@4.9.1, npm/@rollup/rollup-darwin-arm64@4.9.1, npm/@rollup/rollup-darwin-x64@4.9.1, npm/@rollup/rollup-linux-arm-gnueabihf@4.9.1, npm/@rollup/rollup-linux-arm64-gnu@4.9.1, npm/@rollup/rollup-linux-arm64-musl@4.9.1, npm/@rollup/rollup-linux-riscv64-gnu@4.9.1, npm/@rollup/rollup-linux-x64-gnu@4.9.1, npm/@rollup/rollup-linux-x64-musl@4.9.1, npm/@rollup/rollup-win32-arm64-msvc@4.9.1, npm/@rollup/rollup-win32-ia32-msvc@4.9.1, npm/@rollup/rollup-win32-x64-msvc@4.9.1, npm/@sveltejs/kit@2.0.6, npm/@sveltejs/package@2.2.4, npm/@sveltejs/vite-plugin-svelte-inspector@2.0.0, npm/@sveltejs/vite-plugin-svelte@3.0.1, npm/acorn@8.11.2, npm/aria-query@5.3.0, npm/axobject-query@3.2.1, npm/code-red@1.0.4, npm/css-tree@2.3.1, npm/dequal@2.0.3, npm/devalue@4.3.2, npm/esm-env@1.0.0, npm/estree-walker@3.0.3, npm/is-reference@3.0.2, npm/magic-string@0.30.5, npm/mdn-data@2.0.30, npm/periscopic@3.1.0, npm/prettier-plugin-svelte@2.10.1, npm/prettier@2.8.3, npm/rollup@4.9.1, npm/sirv@2.0.4, npm/svelte-hmr@0.15.3, npm/svelte2tsx@0.6.27, npm/svelte@4.2.8, npm/vitefu@0.2.5

View full report↗︎

@rtrampox
Copy link
Contributor Author

Added export from types file, as it can be useful when working around the package.

@ValentinH
Copy link
Owner

Would using the new syntax break the backward compatibility for people using the previous Svelte versions?

@rtrampox
Copy link
Contributor Author

rtrampox commented Dec 23, 2024

Would using the new syntax break the backward compatibility for people using the previous Svelte versions?

From what I found, it seems like yes. Maybe you can publish as an next version of the package?

With the latest version of the package, svelte shows a lot of warnings on the console that some of the reactive statements won't work because they are not supported anymore by Svelte 5.

@ValentinH
Copy link
Owner

Would using the new syntax break the backward compatibility for people using the previous Svelte versions?

From what I found, it seems like yes. Maybe you can publish as an next version of the package?

With the latest version of the package, svelte shows a lot of warnings on the console that some of the reactive statements won't work because they are not supported anymore by Svelte 5.

Oh ok, I didn't know that. Then it totally makes sense to publish this update as a new major version.

src/lib/Cropper.svelte Outdated Show resolved Hide resolved
src/lib/Cropper.svelte Outdated Show resolved Hide resolved
src/lib/Cropper.svelte Show resolved Hide resolved
Copy link

socket-security bot commented Dec 24, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Obfuscated code npm/svelte2tsx@0.7.31 ⚠︎

View full report↗︎

Next steps

What is obfuscated code?

Obfuscated files are intentionally packed to hide their behavior. This could be a sign of malware.

Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/svelte2tsx@0.7.31

src/lib/Cropper.svelte Outdated Show resolved Hide resolved
src/lib/Cropper.svelte Outdated Show resolved Hide resolved
src/lib/Cropper.svelte Outdated Show resolved Hide resolved
@ValentinH ValentinH merged commit 9de3bd8 into ValentinH:main Jan 13, 2025
2 checks passed
@ValentinH
Copy link
Owner

Thank you very much @rtrampox
This is now published as https://github.com/ValentinH/svelte-easy-crop/releases/tag/v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants