Skip to content

Commit

Permalink
chore(explore): Change labels "Group by"/"Series" to "Dimensions" (ap…
Browse files Browse the repository at this point in the history
  • Loading branch information
kgabryje authored and philipher29 committed Jun 9, 2022
1 parent 8d26862 commit aeebb15
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { TIME_COLUMN_OPTION, TIME_FILTER_LABELS } from '../constants';

export const dndGroupByControl: SharedControlConfig<'DndColumnSelect'> = {
type: 'DndColumnSelect',
label: t('Group by'),
label: t('Dimensions'),
default: [],
description: t(
'One or many columns to group by. High cardinality groupings should include a series limit ' +
Expand Down Expand Up @@ -58,7 +58,7 @@ export const dndColumnsControl: typeof dndGroupByControl = {

export const dndSeries: typeof dndGroupByControl = {
...dndGroupByControl,
label: t('Series'),
label: t('Dimensions'),
multi: false,
default: null,
description: t(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ type SelectDefaultOption = {

const groupByControl: SharedControlConfig<'SelectControl', ColumnMeta> = {
type: 'SelectControl',
label: t('Group by'),
label: t('Dimensions'),
multi: true,
freeForm: true,
clearable: true,
Expand Down Expand Up @@ -403,7 +403,7 @@ const sort_by: SharedControlConfig<'MetricsControl'> = {

const series: typeof groupByControl = {
...groupByControl,
label: t('Series'),
label: t('Dimensions'),
multi: false,
default: null,
description: t(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const config: ControlPanelConfig = {
],
controlOverrides: {
groupby: {
label: t('Series'),
label: t('Dimensions'),
validators: [validateNonEmpty],
mapStateToProps: (state, controlState) => {
const groupbyProps =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const config: ControlPanelConfig = {
],
controlOverrides: {
groupby: {
label: t('Series'),
label: t('Dimensions'),
description: t('Categories to group by on the x-axis.'),
},
columns: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const config: ControlPanelConfig = {
name: 'groupby',
config: {
...sharedControls.groupby,
label: t('Group by'),
label: t('Dimensions'),
description: t('Columns to group by'),
},
},
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/src/explore/controls.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ const groupByControl = {
type: 'SelectControl',
multi: true,
freeForm: true,
label: t('Group by'),
label: t('Dimensions'),
default: [],
includeTime: false,
description: t(
Expand Down Expand Up @@ -393,7 +393,7 @@ export const controls = {

series: {
...groupByControl,
label: t('Series'),
label: t('Dimensions'),
multi: false,
default: null,
description: t(
Expand Down

0 comments on commit aeebb15

Please sign in to comment.