Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.sh: Handle Podman Docker Wrapper #7439

Open
wants to merge 2 commits into
base: proton_8.0
Choose a base branch
from

Conversation

K1ngst0m
Copy link

@K1ngst0m K1ngst0m commented Jan 24, 2024

The function check_container_engine needs to be modified to ensure that inner_uid captures only the numeric UID or a "Permission denied" message (for SELinux), and ignores any other messages generated by the wrapper script like this.

#!/usr/bin/sh
[ -e /etc/containers/nodocker ] || \
echo "Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg." >&2
exec podman "$@"

the inner_uid variable would be assigned the "Emulate Docker CLI ..." string when using podman's docker wrapper.

A temporary file is created to store the command's output so that the code can check both the return code and console output.

@K1ngst0m K1ngst0m force-pushed the handle_podman_wrapper branch from 97e8767 to be96920 Compare January 24, 2024 23:08
@K1ngst0m K1ngst0m force-pushed the handle_podman_wrapper branch from be96920 to c197248 Compare January 24, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant