[TF2] fix IncrementAmmo removing ammo if m_iClip1 was already at Max capacity #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitl
added a commit
to BitlDevelopmentStudios/source-sdk-2013-bds-base
that referenced
this pull request
Jul 6, 2025
Contributor
|
How does this interact with the Bazooka (and other weapons that use the Bazooka's reload setup)? |
Contributor
Author
good catch. I forgot about those reloads. Will update shortly |
Contributor
Author
I misinterpreted your question, so ignore that other PR. it works as expected. |
Contributor
Sounds good, was just doublechecking as I wasn't sure what the behavior was during that reload type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a player were to touch a resupply during a reload it would then still remove ammo from the player even though the weapons clip is already full. This prevents this by only removing ammo if m_iClip1 is smaller than the max clip capacity.
Before:
2025-07-05.13-52-47.mp4
After:
2025-07-05.13-59-55.mp4