New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace almost all pp.Combine() into pp.Regex() #60

Open

embar- wants to merge 1 commit into Vanderhoof:master from embar-:combine2regex

embar- commented Mar 1, 2025

Majority of pp.Combine() are replaced into pp.Regex() for optimization.
Only this one line is not changed:

PyDBML/pydbml/definitions/enum.py

Line 56 in 2bf015c

enum_name = pp.Combine(name("schema") + '.' + name("name")) | name("name")

This will contribute to #59 solving

Some metrics:


Before	After


Before	After


          Replace almost all pp.Combine() into pp.Regex()

75e94d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet