Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/371 Add YML extension support for stacks and pkgmanagers #373

Merged
merged 5 commits into from
Jul 13, 2024
Merged

feat/371 Add YML extension support for stacks and pkgmanagers #373

merged 5 commits into from
Jul 13, 2024

Conversation

deepu9
Copy link
Contributor

@deepu9 deepu9 commented Jul 2, 2024 •
edited
Loading

Closes #371

  1. Added an utility function to check whether YAML or YML file based on their availability.
  2. Updated references to hardcoded .yaml files with utility function.

NOTE TO REVIEWERS: Regards to the utility function ChooseYamlFile, can you provide any suggestions on the name.

deepu9 added 2 commits July 2, 2024 18:19
@deepu9
feat: [Vanilla-OS#371] Add YML extension support for stacks and pkgma…
10cda7f 
…nagers

Added util function to choose either YAML or YML file depeneds on
availability. Updated all the references in stack and pkgManager files with util function.
@deepu9
Merge branch 'main' into feat/371-add-yml-support-for-stacks-pkgmanagers
f22dd1f
@mirkobrombin
Copy link
Member

I would use Select instead of Choose

@deepu9
Copy link
Contributor Author

deepu9 commented Jul 3, 2024

I would use Select instead of Choose

Thanks @mirkobrombin. I'll update it.

@deepu9
fix: [Vanilla-OS#371] Add YML extension support for stack and pkgmana…
1687d91 
…gers

Updated the util function name to SelectYamlFile.
@deepu9 deepu9 marked this pull request as ready for review July 4, 2024 01:16
@kbdharun kbdharun requested a review from mirkobrombin July 7, 2024 15:59
mirkobrombin
mirkobrombin approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM

@mirkobrombin mirkobrombin merged commit c471396 into Vanilla-OS:main Jul 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkobrombin mirkobrombin mirkobrombin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: add support for YML file extension for stacks, pkgmanagers
2 participants
@deepu9 @mirkobrombin