Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:[#373] add decibels to apps list #382

Merged
merged 3 commits into from
Mar 11, 2025
Merged

feat:[#373] add decibels to apps list #382

merged 3 commits into from
Mar 11, 2025

Conversation

jardon
Copy link
Member

@jardon jardon commented Mar 10, 2025 •
edited
Loading

closes #373

@jardon jardon force-pushed the feat/add-decibels-core branch from 628c4da to 51db026 Compare March 10, 2025 00:51
@jardon jardon force-pushed the feat/add-decibels-core branch from 51db026 to d0c5eca Compare March 10, 2025 01:02
@jardon jardon marked this pull request as ready for review March 10, 2025 01:02
@jardon jardon requested a review from taukakao March 10, 2025 01:34
kbdharun
kbdharun reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, I have some minor suggestions for this PR (IG we could do both the addition of Decibels and removal of GNOME Music here).

@jardon jardon requested a review from kbdharun March 10, 2025 22:30
taukakao
taukakao approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@taukakao taukakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taukakao taukakao merged commit f2f8cb5 into main Mar 11, 2025
3 checks passed
@taukakao taukakao deleted the feat/add-decibels-core branch March 11, 2025 00:11
@taukakao
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taukakao taukakao taukakao approved these changes

@kbdharun kbdharun Awaiting requested review from kbdharun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace GNOME Music with Decibles
3 participants
@jardon @taukakao @kbdharun