Fixed errors with tksheet versions 5.0.29+ #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VarunS2002
added a commit
that referenced
this pull request
Mar 11, 2022
Fixed errors with tksheet versions 5.0.29+
|
Thanks for the fix ! @yjagota |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small change that fixes issues when tksheet v5.0.29 or above is used with this script. The problem is that the add_columns parameter to insert_row was defaulted to false in v5.0.29 of tksheet, which caused no data to be loaded to the table, and as a result, caused error at self.sheet.see(last_row) as there are no rows in the table.
Fixes #24, #25, #28, #32, #33.