-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Vagrant hosts updating plugin? #606
Comments
I (obviously) have no objections here. For context, vagrant-hostsupdater was itself a fork of yet another unmaintained project (that broke when Vagrant changed the plugins API version a while back). We forked yet again so we could polish off some unimplemented features of the plugin. Namely, command line usage. In addition to setting the I can definitely put together a PR for this change. Note: @johnpbloch did the original forking work, but the plugin had to be co-located in another repo for testing. He lost props for his efforts when I migrated things into its own repository. I point this out to emphasize the project is supported by more than just me. |
This seems interesting. How far from the original hostsupdater does the 10up fork get? and would it still be possible to add the commands to the host's sudoers file to skip the password each time? I believe I have a script that works with the plugins now. https://gist.github.com/EHLOVader/606f7c9f8717608527b8 |
It cleans up a bit of the documentation, removes some dead code, and adds the ability to run The "original" hostsupdater plugin was itself a fork of another plugin. The real original plugin wasn't updated to the v2 of the Vagrant plugin API, so it stopped working a while ago. Hostsupdater forked and updated some of the code, but skipped the CLI entirely (even though it reports as being available with The entire point of the Ghost fork is to keep the plugin alive (there's no guarantee that Vagrant will stick with the v2 plugins API) and to rebuild the CLI components of the plugin. Aside from that, we also switched to referring to an |
On top of that, we also cleaned up how it behaves. The old plugin sometimes wouldn't add/remove hosts based on a variety of factors including what state the machine was transitioning into, or configuration options that prevented it from running on suspend by default. The new behavior is:
Basically, if the vm isn't up and running, the hosts should not be in your host file. |
@ericmann does this mean it will break auto setup sites? |
Hey @jeremyfelt , I'll be releasing some fixes to vagrant-hostsupdater as I was added to the repo. I would love to include any contributions to help improve the project. I will also look at pulling in vagrant ghost changes into the repo. |
Use the vagrant-ghost plugin to consolidate and manage hostfiles instead of the current vagrant-hostsupdater. This doesn't take advantage of the hosts collection that Ghost provides, since it only looks for the `aliases` file for additional hostnames. Instead, it keeps the existing hosts array generation, then passes that array to the Ghost config for further management. See Varying-Vagrant-Vagrants#606.
I'm going to close this out. vagrant-hostsupdater is an active project at this point. Thanks for picking it up, @cgsmith! :) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
vagrant-hostsupdater hasn't been updated in a while and may or may not be stable with current environments. See #603 as an example.
10up has a fork of vagrant-hostsupdater in Vagrant Ghost. @ericmann any thoughts on that being a stable replacement?
@zamoose Does HGV have any plans along these lines? I did a search and only ran into one related issue (HGV#40).
The text was updated successfully, but these errors were encountered: