Remove attempt to enforce ipv4 in postfix #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #420, we added a line to provisioning that attempts to set "ipv4" as the only allowed protocol for postfix due to issues in how network connections managed the ipv6 connection.
Because the config file does not yet exist during initial provisioning, that caused an error message saying as much. See #628.
It turns out that this line hasn't been doing anything. :)
I first went down the path of using
debconf-set-selections
to set the protocol value. This works, but then disables ipv6 entirely as a valid protocol. Since we haven't heard of any other issuesbesides the original in #420, I think it's safe to not make any change here and then watch for any problems.
I have a feeling that postfix has gotten better about this. In the documentation for the
inet_protocols
config, it's mentioned that "versions before 2.8 attempt to connect via IPv6 before attempting to use IPv4."http://www.postfix.org/postconf.5.html#inet_protocols
Now that we're past 2.8, it's entirely possible that the protocol detection has gotten better. If we do run into an issue, there is a newer
smtp_address_preference
config that allows us to specifywhich protocol should be attempted first.
http://www.postfix.org/postconf.5.html#smtp_address_preference
In that case, we may need to create our own custom config file as it's not entirely obvious that
debconf-set-selections
will work for this value.See #420.
Fixes #628.