Speed up checking for vvv-hosts files

[davecpage]

The existing recursive blob causes massive slowdown of everything (provision, ssh etc) once I've got a few projects setup, especially if they have numerous directories.

This change limits the lookups to only look at the primary directory and a provision subfolder rather than unlimited depth. This matches what is documented, though other code such as provision-site.sh still looks 4 levels deep.

On my setup doing vagrant ssh returns in seconds rather than potentially minutes. Should be useful in situations such as https://jjj.blog/2016/05/slow-vagrant/

Related: #595

[LoreleiAurora]

This could break site provisioners that rely on scanning for vvv-hosts multiple levels deep.
For example WordPress/meta-environment keeps its host files 3 levels deep.

Instead i think we should just restrict this to 4 levels deep bringing the hosts file on the hosts machine in sync with the hosts file on the VM.

[davecpage]

@LoreleiAurora I've rewritten the line to be more generic but restricted to 4 levels deep. Have checked locally using WordPress/meta-environment and it still picks up the vvv-hosts files but is still much faster in provisioning, vagrant ssh etc.

[LoreleiAurora]

Looking at this again we need to come up with a different way to do the scan. the scan 4 levels deep in provision-site.sh is relative to a site dir where as this is relative to the www root.

[tomjn]

This makes sense, I don't think more than 4 levels deep is necessary, as long as the docs are updated

[davecpage]

Looking into it a bit more, the vvv-hosts code within Vagrantfile only looks within the www root hierarchy whereas the docs state that with custom paths the site local_dir path could be anywhere. With a custom local_dir the vvv-hosts file would only be used within provision-site.sh so any custom hosts would have to be duplicated in vvv-custom.yml otherwise nothing would be added to the hosts file on the hosts machine. At least that's how i'm reading it.

As the docs state that using vvv-custom.yml is the recommendation for setting hosts and a vvv-hosts file is only for backwards compatibility would a better solution be to see if hosts have been set in vvv-custom.yml and if not only then to look within that sites' local_dir to find a vvv-hosts file?

[LoreleiAurora]

Personally i would go for the approach of

1. Fix hosts files to scan site dirs
2. Add a skip_vvv_hosts: true flag so the scan can be turned off globally and per site

This approach would prevent breaking bc.

@jeremyfelt @tomjn Thoughts?

[davecpage]

How about this? Covers point 1. Priority is hosts defined in vvv-custom.yml then on each site checks within the local_dir 4 directories deep for any vvv-hosts files to add those hosts.
Looking to add point 2 next.

[LoreleiAurora]

You can shorten these 2 lines to

site_host_paths = Dir.glob(Array.new(4) {|i| vvv_config['sites'][site]['local_dir'] + '/*'*(i+1) + '/vvv-hosts'})

[LoreleiAurora]

I have left a comment inline. Once this change is made this can be merged and a seperate ticket opened for skip_vvv_hosts: true

[davecpage]

Have made that change, getting used to using Ruby so didn't realise that that was possible.