Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning when the Parallels plugin isn't installed #2670

Merged
merged 3 commits into from
May 22, 2023

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented May 19, 2023

When specifying Parallels as a provider, if the plugin isn't installed you get an error:

Message: NameError: uninitialized constant VagrantPlugins::Parallels

This checks if that is defined before trying to fetch the parallels version

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

When specifying Parallels as a provider, if the plugin isn't installed you get an error:

Message: NameError: uninitialized constant VagrantPlugins::Parallels

This checks if that is defined before trying to fetch the parallels version
@update-docs
Copy link

update-docs bot commented May 19, 2023

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn tomjn added the type:bug label May 19, 2023
@tomjn tomjn marked this pull request as ready for review May 21, 2023 15:15
@tomjn tomjn requested a review from a team May 21, 2023 15:16
@tomjn tomjn merged commit d7b96f6 into develop May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants