Simplify private network overrides #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the benefit of making it trivial to change the IP address from the Customfile without modifying Vagrantfile
What! That's crazy talk. I had no idea the |
jeremyfelt
added a commit
that referenced
this pull request
Nov 3, 2015
Simplify private network overrides
|
@jeremyfelt I know, right?? I didn't know either until this morning when I was trying to get this working another way! It took me an hour digging through undocumented ruby in the vagrant repo to find that little gem! Proof! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ostensibly an improvement for hyperv providers, but carries extra benefits for all providers.
Hyper-V does not know how to make private networks, so the extra IP address configured by VVV is not needed (and when used with vagrant ghost, results in duplicate hosts entries that point to a dud address). This unsets the private network for the hyperv provider.
Additionally, this makes it much easier and more forwards-compatible to modify the VM ip address. Currently, if you need to change the vm's network (e.g. because your network is using the 192.168.50.* subnet), you must edit
Vagrantfiledirectly. With an id for the network config, the ip can be overridden in theCustomfilein one line: