Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JEI plugin failure when no potions are registered to the zeta registry, fix crash from ForgeZGatherHints #50

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

mezz
Copy link
Contributor

@mezz mezz commented Sep 8, 2024

This PR fixes two issues:

  • This getRegisteredObjects method can currently return null and crash the JEI plugin.
  • ForgeZGatherHints needs to implement IModBusEvent in order to be fired on the mod even bus

@mezz mezz changed the title Fix JEI plugin failure when no potions are registered to the zeta registry Fix JEI plugin failure when no potions are registered to the zeta registry, fix crash from ForgeZGatherHints Sep 10, 2024
@IThundxr IThundxr merged commit 72376d4 into VazkiiMods:main Sep 10, 2024
1 check failed
@mezz mezz deleted the jei-crash branch September 10, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants