Fix vector call linking with trigonometric functions #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -338,6 +338,7 @@ int main() { return 0; } | |||
| add_definitions(-D_CRT_SECURE_NO_WARNINGS) | |||
| endif() | |||
| vc_add_compiler_flag(Vc_COMPILE_FLAGS "/Gv") # default to __vectorcall | |||
| vc_add_compiler_flag(Vc_COMPILE_FLAGS "/bigobj") # required for building tests with AVX | |||
There was a problem hiding this comment.
I tested locally and this option is indeed required for debug builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to compile Vc with AVX and C++17 on MSVC.
I was getting the same errors as #230 and took the suggestion of #147 to add
__vectorcallto the right places, at least for the trigonometric functions.