Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector call linking with trigonometric functions #274

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

EricAtORS
Copy link
Contributor

I'm trying to compile Vc with AVX and C++17 on MSVC.
I was getting the same errors as #230 and took the suggestion of #147 to add __vectorcall to the right places, at least for the trigonometric functions.

@@ -338,6 +338,7 @@ int main() { return 0; }
add_definitions(-D_CRT_SECURE_NO_WARNINGS)
endif()
vc_add_compiler_flag(Vc_COMPILE_FLAGS "/Gv") # default to __vectorcall
vc_add_compiler_flag(Vc_COMPILE_FLAGS "/bigobj") # required for building tests with AVX
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and this option is indeed required for debug builds.

@bernhardmgruber bernhardmgruber merged commit 61cac17 into VcDevel:1.4 Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants