Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve MSVC version from cl.exe #298

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

bernhardmgruber
Copy link
Collaborator

This PR lets the ctest script retrieve the MSVC version from cl.exe instead of by compiling ./cmake/msvc_version.c, which has been deleted in #290.

@bernhardmgruber
Copy link
Collaborator Author

I see the MSVC version strings appearing in cdash :)

@amadio
Copy link
Collaborator

amadio commented Aug 31, 2021

You know CMake has CMAKE_CXX_COMPILER_VERSION, right? :-)

@bernhardmgruber
Copy link
Collaborator Author

bernhardmgruber commented Aug 31, 2021

You know CMake has CMAKE_CXX_COMPILER_VERSION, right? :-)

Yes, but does it have that variable in the dashboard client script for ctest? ;-D

Edit: just tried it, the variable is empty in inside test.cmake.

@amadio
Copy link
Collaborator

amadio commented Aug 31, 2021

Yeah, I forgot that I actually detect this information using cmake --system-information in veccore/cmake/TestVecCore.cmake... We can copy that piece of code for Vc's test.cmake, because that works for all compilers, not just MSVC.

@bernhardmgruber
Copy link
Collaborator Author

I would prefer my simple fix for this PR. But we can sure consider simplifying test.cmake a lot by copying from veccore in a subsequent PR.

@amadio amadio merged commit 7def5cc into VcDevel:1.4 Sep 1, 2021
@bernhardmgruber bernhardmgruber deleted the msvc_ver_ctest branch September 1, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants