Fix MaskBool initialization on SSE #300
Merged
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
approved these changes
Sep 3, 2021
| return MaskBool(m.d.m(i)); | ||
| return m.toInt() & (1 << i); |
There was a problem hiding this comment.
I guess that works. Looking at the previous implementation, it aliased the vector register by a T array and then accessed at i. That is what's happening in m.d.m(i). So that might fore storing the register to memory. Your solution probably stays within the registers and might even be more efficient. AVX also uses your implementation.
amadio
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255 by initializing the mask in the same way as AVX.
Includes a test that will assess the condition if Vc is compiled with
-DCMAKE_CXX_FLAGS=-ffinite-math-only. (In all other cases it'll always return true, as explained by the reporter.)