Update README #324
Merged
Update README #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadio
reviewed
Mar 31, 2022
|
|
||
| ```sh | ||
| $ cmake -DCMAKE_INSTALL_PREFIX=/opt/Vc -DBUILD_TESTING=OFF <srcdir> | ||
| $ cmake -DBUILD_TESTING=OFF .. |
There was a problem hiding this comment.
How about making BUILD_TESTING off by default and adding -DBUILD_TESTING=ON to the CI?
There was a problem hiding this comment.
We could do that, but that could affect a lot of downstream users. Let's do that in a separate PR.
There was a problem hiding this comment.
New PR here: #325
1 task
|
Is this ready to be merged? |
|
Yes, please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes more platform agnostic build/install instructions and a note that Vc is now in maintenance mode.