Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use ReBased Linear Attention and RingAttention #51

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kabachuha
Copy link

@kabachuha kabachuha commented Mar 5, 2024

Not tested yet, as it needs training runs, but I think it can be helpful for you

ReBased repo: https://github.com/corl-team/rebased

Ring Attention implementation by Lucidrains https://github.com/lucidrains/ring-attention-pytorch

@maxin-cn
Copy link
Collaborator

maxin-cn commented Mar 5, 2024

Not tested yet, as it needs training runs, but I think it can be helpful for you

ReBased repo: https://github.com/corl-team/rebased

Thanks for your PR, we will check it.

@kabachuha kabachuha changed the title Option to use Linear Attention from ReBased Option to use ReBased Linear Attention and RingAttention Mar 6, 2024
@bhack
Copy link

bhack commented Mar 8, 2024

Be aware that there could be some problem in the case you want to compile it
pytorch/pytorch#121386

@KimmiShi
Copy link

ring attention is not the most efficient method for this model.

@maxin-cn maxin-cn assigned maxin-cn and KimmiShi and unassigned maxin-cn Mar 21, 2024
@maxin-cn maxin-cn added the enhancement New feature or request label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants