Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化、改善【单独搜索一个页面】功能 #236

Open
Tracked by #250 ...
VecHK opened this issue Jul 22, 2023 · 0 comments
Open
Tracked by #250 ...

优化、改善【单独搜索一个页面】功能 #236

VecHK opened this issue Jul 22, 2023 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation improve
Milestone

Comments

@VecHK
Copy link
Owner

VecHK commented Jul 22, 2023

首先,使用这个功能,搜索词的开头会带上一个空格,这个应该要解决。

其次,我希望用这个功能打开的搜索页面的tab是插入到当前tab页的后边(就像新标签打开链接一样),而不是现在像是command+tab那样tab页直接放在最后面。

最后,还要能去判断OnInputEnteredDisposition,判定出三种打开方式(相当于按下 Enter键、Command+回车键、Shift+Command+回车键)

打开方式的逻辑:

  • 按下 Shift+Command+Enter键 的时候,是创建一个新窗口
  • 按下 Command+Enter键、Enter键 的时候,是创建一个 Tab
    • 新创建的 Tab 的位置,是当前 Tab 的后面,而不是 Tab 栏最末尾的位置
    • 如果已经创建过 Tab,逻辑则是一直往右边数,直到不是创建的 Tab 为止的位置为新创建的 Tab 的位置
@VecHK VecHK added bug Something isn't working improve labels Jul 22, 2023
@VecHK VecHK added this to the 2.X milestone Jul 22, 2023
@VecHK VecHK mentioned this issue Jul 23, 2023
16 tasks
@VecHK VecHK linked a pull request Jul 23, 2023 that will close this issue
16 tasks
VecHK added a commit that referenced this issue Jul 23, 2023
@VecHK VecHK added the documentation Improvements or additions to documentation label Jul 23, 2023
@VecHK VecHK changed the title 【单独搜索一个页面】的问题 优化、改善【单独搜索一个页面】功能 Jul 23, 2023
VecHK added a commit that referenced this issue Jul 23, 2023
@VecHK VecHK removed a link to a pull request Jul 29, 2023
16 tasks
@VecHK VecHK mentioned this issue Jul 29, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation improve
Projects
None yet
Development

No branches or pull requests

1 participant